From: Junio C Hamano <junkio@cox.net>
To: Joel Becker <Joel.Becker@oracle.com>
Cc: git@vger.kernel.org
Subject: Re: git-commit: allow From: line to be entered in commit message
Date: Thu, 12 Jan 2006 12:22:53 -0800 [thread overview]
Message-ID: <7vhd89mc0y.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060112190031.GH14196@ca-server1.us.oracle.com> (Joel Becker's message of "Thu, 12 Jan 2006 11:00:31 -0800")
Joel Becker <Joel.Becker@oracle.com> writes:
> On Thu, Jan 12, 2006 at 09:37:00AM -0500, sean wrote:
>> Use the author name and email information given as the
>> first line of the commit message in the form of:
>>
>> From: name <email>
>>
> If we do this, can we have it populated up front? That is, when
> the edit opens, the current idea of author is in the comments as "From:"
> so I can see what the author would be if I changed nothing. This would
> catch surprises where I'd forgotten to set AUTHOR_*, etc.
Committing somebody else's changes by hand ought to be a rare
event. Otherwise that is an indication that there needs to be a
"git am/applymbox" equivalent for the mythical transport medium
(other than e-mail) that feeds you somebody else's changes to
you and have you commit. If something is a regular event in a
workflow, we would want to be able to automate things, and
having the user type in whom the changes have come from is not
the way to do it.
Most of the time when I use "git commit", I'll be committing my
own changes; I do not want to see "From: me" every time I
commit.
"Populate upfront, only if it is different from yourself" is
perhaps acceptable, but that is probably hard to arrange. There
is no reliable way to know what is "yourself", and that was why
we have GIT_AUTHOR_* environment variables to override things to
begin with.
next prev parent reply other threads:[~2006-01-12 20:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060112093700.1d3d25db.seanlkml@sympatico.ca>
2006-01-12 14:37 ` git-commit: allow From: line to be entered in commit message sean
[not found] ` <20060112102123.581e373e.seanlkml@sympatico.ca>
2006-01-12 15:21 ` sean
2006-01-12 20:13 ` Junio C Hamano
2006-01-12 21:53 ` Andreas Ericsson
2006-01-12 22:15 ` Junio C Hamano
[not found] ` <20060112214307.174f5719.seanlkml@sympatico.ca>
2006-01-13 2:43 ` sean
[not found] ` <20060112213207.05d76b28.seanlkml@sympatico.ca>
2006-01-13 2:32 ` sean
2006-01-13 4:03 ` Junio C Hamano
[not found] ` <20060112230633.0858694a.seanlkml@sympatico.ca>
2006-01-13 4:06 ` sean
2006-01-13 4:35 ` Junio C Hamano
[not found] ` <20060112235103.42665813.seanlkml@sympatico.ca>
2006-01-13 4:51 ` sean
2006-01-13 11:11 ` Artem Khodush
2006-01-13 17:40 ` Junio C Hamano
[not found] ` <20060113125404.58c4ce30.seanlkml@sympatico.ca>
2006-01-13 17:54 ` sean
2006-01-13 19:51 ` Junio C Hamano
2006-01-13 21:53 ` Johannes Schindelin
2006-01-12 19:00 ` Joel Becker
2006-01-12 20:22 ` Junio C Hamano [this message]
2006-01-13 6:58 ` Joel Becker
2006-01-13 7:06 ` Junio C Hamano
2006-01-13 19:12 ` Joel Becker
2006-01-13 19:39 ` Junio C Hamano
2006-01-13 20:01 ` Joel Becker
2006-01-13 20:33 ` Junio C Hamano
2006-01-13 20:46 ` Junio C Hamano
2006-01-13 21:47 ` Johannes Schindelin
2006-01-12 20:16 ` Alex Riesen
[not found] ` <20060112214642.3c88282c.seanlkml@sympatico.ca>
2006-01-13 2:46 ` sean
2006-01-13 3:58 ` Junio C Hamano
[not found] ` <20060112225800.411a04c1.seanlkml@sympatico.ca>
2006-01-13 3:58 ` sean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhd89mc0y.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Joel.Becker@oracle.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).