From: Junio C Hamano <junkio@cox.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] diff-tree: stop on broken output pipe
Date: Fri, 06 Jan 2006 14:36:50 -0800 [thread overview]
Message-ID: <7vhd8ht24d.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: Pine.LNX.4.63.0601020116020.11331@wbgn013.biozentrum.uni-wuerzburg.de
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Without this, on my iBook git-whatchanged keeps running when I
> quit "less". I have to interrupt the process a second time. No
> idea why it works on Linux.
>
> - if (!no_commit_id)
> - printf("%s%c", header, diff_options.line_termination);
> + if (!no_commit_id && printf("%s%c", header,
> + diff_options.line_termination) < 0)
> + die("broken output pipe");
> header = NULL;
There are tons of output other than this printf() and catching
an output error only on this one and assuming that is a broken
pipe somehow feels doubly wrong to me.
next prev parent reply other threads:[~2006-01-06 22:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-02 0:17 [PATCH] diff-tree: stop on broken output pipe Johannes Schindelin
2006-01-02 1:21 ` Andreas Ericsson
2006-01-02 11:01 ` Johannes Schindelin
2006-01-06 22:36 ` Junio C Hamano [this message]
2006-01-07 0:41 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhd8ht24d.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).