From: Junio C Hamano <junkio@cox.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fetch-pack should not ask for a ref which is already there
Date: Thu, 29 Sep 2005 02:14:28 -0700 [thread overview]
Message-ID: <7vhdc4grrf.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.63.0509291034450.20717@wgmdd8.biozentrum.uni-wuerzburg.de> (Johannes Schindelin's message of "Thu, 29 Sep 2005 10:42:32 +0200 (CEST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Yeah, sorry. I did not test that one. Maybe an automated test for
> git-fetch-pack would be useful after all...
Sounds sensible. I think git-send-pack has one.
> How about the following? (I avoided an ugly goto, but had to duplicate
> code :-( )
I suspect it would be cleaner to return (struct ref *) from
fetch_pack (ideally use NULL to signal failure but there is no
need -- it just dies) and print the refs from main() only after
seeing the last close and finish_connect succeed.
next prev parent reply other threads:[~2005-09-29 9:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-28 23:49 [PATCH] fetch-pack should not ask for a ref which is already there Johannes Schindelin
2005-09-29 7:22 ` Junio C Hamano
2005-09-29 8:42 ` Johannes Schindelin
2005-09-29 9:14 ` Junio C Hamano [this message]
2005-09-29 9:30 ` Johannes Schindelin
2005-09-29 18:26 ` Linus Torvalds
2005-09-29 19:08 ` Johannes Schindelin
2005-09-29 19:28 ` Johannes Schindelin
2005-09-29 21:07 ` Linus Torvalds
2005-09-30 12:20 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhdc4grrf.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).