git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Josef Weidendorfer <Josef.Weidendorfer@gmx.de>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Added hook in git-receive-pack
Date: Sun, 31 Jul 2005 17:11:20 -0700	[thread overview]
Message-ID: <7vhdeabjo7.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0507311627280.14342@g5.osdl.org> (Linus Torvalds's message of "Sun, 31 Jul 2005 16:33:53 -0700 (PDT)")

Linus Torvalds <torvalds@osdl.org> writes:

> In the "central repo model" you have another issue - you have potentially
> parallell pushes to different branches with no locking what-so-ever (and
> that's definitely _supposed_ to work), and I have this suspicion that the 
> "update for dumb servers" code isn't really safe in that setting anyway. I 
> haven't checked.

You are absolutely right.  It should grab some sort of lock
while it does its thing (would fcntl(F_GETLK) be acceptable to
networked filesystem folks?).

I have one question regarding the hooks.  We seem to prefer
avoiding system and roll our own.  Is there a particular reason,
other than bypassing the need to quote parameters for shell?

  reply	other threads:[~2005-08-01  0:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-31 19:17 [PATCH] Added hook in git-receive-pack Josef Weidendorfer
2005-07-31 20:11 ` Linus Torvalds
2005-07-31 20:33   ` Junio C Hamano
2005-07-31 22:50     ` Linus Torvalds
2005-07-31 23:24       ` Junio C Hamano
2005-07-31 23:31         ` Johannes Schindelin
2005-07-31 23:33         ` Linus Torvalds
2005-08-01  0:11           ` Junio C Hamano [this message]
2005-08-01  0:25             ` Linus Torvalds
2005-07-31 20:15 ` Junio C Hamano
2005-07-31 23:17   ` Josef Weidendorfer
2005-08-01  8:14     ` Junio C Hamano
2005-08-13 18:31 ` Josef Weidendorfer
2005-08-13 19:27   ` Junio C Hamano
2005-08-13 20:39     ` Josef Weidendorfer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vhdeabjo7.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=Josef.Weidendorfer@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).