From: Junio C Hamano <gitster@pobox.com>
To: Tim Henigan <tim.henigan@gmail.com>
Cc: gitster@pobox.com, git@vger.kernel.org, davvid@gmail.com,
ramsay@ramsay1.demon.co.uk
Subject: Re: [PATCH 8/9 v12] difftool: teach difftool to handle directory diffs
Date: Thu, 12 Apr 2012 11:27:10 -0700 [thread overview]
Message-ID: <7viph46c1t.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1334236726-18393-1-git-send-email-tim.henigan@gmail.com> (Tim Henigan's message of "Thu, 12 Apr 2012 09:18:46 -0400")
Tim Henigan <tim.henigan@gmail.com> writes:
> +sub setup_dir_diff
> +{
> + # Run the diff; exit immediately if no diff found
> + my $cmd = "git diff --raw --no-abbrev -z " . join(" ", @ARGV);
> + my $diffrtn = `$cmd` or die $!;
Why this change? It looks like a rather unpleasant regression compared to
the previous one that used "command_oneline", so that each element of
@ARGV was given as a single argument to the command. Now, you are
splitting any argument that has $IFS in it.
next prev parent reply other threads:[~2012-04-12 18:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 13:18 [PATCH 8/9 v12] difftool: teach difftool to handle directory diffs Tim Henigan
2012-04-12 18:27 ` Junio C Hamano [this message]
2012-04-12 19:10 ` Tim Henigan
2012-04-12 19:31 ` Junio C Hamano
2012-04-13 2:53 ` David Aguilar
2012-04-13 16:31 ` Tim Henigan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7viph46c1t.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=tim.henigan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).