From: Junio C Hamano <gitster@pobox.com>
To: James Blackburn <jamesblackburn@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git rebase fails with: Patch does not have a valid e-mail address.
Date: Thu, 08 Sep 2011 14:21:12 -0700 [thread overview]
Message-ID: <7vipp2wx13.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CACyv8dc28sRWsObYi3vbFNakj=R-2Q9eAoJdFfqNxsqq2+_aPg@mail.gmail.com> (James Blackburn's message of "Thu, 8 Sep 2011 18:21:06 +0100")
James Blackburn <jamesblackburn@gmail.com> writes:
>> Perhaps you used "filter-branch" for conversion and your "doesn't
>> ordinarily complain about this" refers to it? If so, I have to say that it
>> is filter-branch that needs to be fixed to error out.
>
> I use cvs2git for the conversion (which produces a fast-import
> stream). That tool doesn't enforce an email address, and it's only
> when I try to rebase that I run into this problem... AFAICS there's
> nothing fundamentally wrong with what I'm trying to do, so forcing me
> to re-write the author seems to be the wrong answer, no?
Sorry, I do not follow. Nobody is forcing you to rewrite the author, but
earlier didn't you say _you_ rewrote the author into that invalid empty
string yourself, no?
next prev parent reply other threads:[~2011-09-08 22:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 11:47 git rebase fails with: Patch does not have a valid e-mail address James Blackburn
2011-09-08 17:15 ` Junio C Hamano
[not found] ` <CACyv8dc28sRWsObYi3vbFNakj=R-2Q9eAoJdFfqNxsqq2+_aPg@mail.gmail.com>
2011-09-08 21:21 ` Junio C Hamano [this message]
2011-09-09 4:45 ` Kyle Moffett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vipp2wx13.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jamesblackburn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox