From: Junio C Hamano <gitster@pobox.com>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Test 9500 - unhelpful without Perl::CGI
Date: Wed, 15 Jun 2011 09:51:15 -0700 [thread overview]
Message-ID: <7vips7jaws.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <BANLkTinAfqysABm+t_NkOGO2U+iy57WbVQ@mail.gmail.com> (Sverre Rabbelier's message of "Wed, 15 Jun 2011 09:26:03 +0200")
Sverre Rabbelier <srabbelier@gmail.com> writes:
> On Wed, Jun 15, 2011 at 07:59, Junio C Hamano <gitster@pobox.com> wrote:
>> +perl -MCGI -MCGI::Util -MCGI::Carp -e 0 >/dev/null 2>&1 || {
>> + skip_all='skipping gitweb tests, CGI module unusable'
>> + test_done
>> +}
>> +
>
> Isn't the new style to use test_must_succeed CGI_AVAILABLE '...' '...'
> rather than skip_all+test_done?
I do not think that adds any value, at least in this case. Besides, look
at the context line above what you quoted ;-)
next prev parent reply other threads:[~2011-06-15 16:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 2:37 Test 9500 - unhelpful without Perl::CGI Linus Torvalds
2011-06-15 5:59 ` Junio C Hamano
2011-06-15 7:26 ` Sverre Rabbelier
2011-06-15 16:51 ` Junio C Hamano [this message]
2011-06-15 17:05 ` Junio C Hamano
2011-06-15 18:36 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vips7jaws.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=srabbelier@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).