From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] checkout: honor advice.detachedHead when reattaching to a branch
Date: Tue, 24 May 2011 14:24:37 -0700 [thread overview]
Message-ID: <7vipsz7pwq.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20110524202723.GG584@sigill.intra.peff.net> (Jeff King's message of "Tue, 24 May 2011 16:27:23 -0400")
Jeff King <peff@peff.net> writes:
>> @@ -668,8 +671,6 @@ static void orphaned_commit_warning(struct commit *commit)
>> die("internal error in revision walk");
>> if (!(commit->object.flags & UNINTERESTING))
>> suggest_reattach(commit, &revs);
>> - else
>> - describe_detached_head("Previous HEAD position was", commit);
>> }
>
> Wait, I thought we were keeping this, per your argument above?
Well, I do not have very strong preference either way. I didn't really
argue for or against. I just explained it might be useful.
Will resurrect.
prev parent reply other threads:[~2011-05-24 21:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 20:35 [PATCH] checkout: honor advice.detachedHead when reattaching to a branch Junio C Hamano
2011-05-06 22:38 ` Jeff King
2011-05-06 22:59 ` Junio C Hamano
2011-05-06 23:21 ` Jeff King
2011-05-07 1:38 ` Jeff King
2011-05-24 17:11 ` Junio C Hamano
2011-05-24 20:27 ` Jeff King
2011-05-24 21:24 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vipsz7pwq.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).