From: Junio C Hamano <gitster@pobox.com>
To: David Aguilar <davvid@gmail.com>
Cc: "Frédéric Heitzmann" <frederic.heitzmann@gmail.com>,
"Michael J Gruber" <git@drmicha.warpmail.net>,
git@vger.kernel.org
Subject: Re: [PATCH 3/3] git-mergetool--lib: Make vimdiff retain the current directory
Date: Mon, 23 May 2011 12:59:34 -0700 [thread overview]
Message-ID: <7vipt1ur15.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1306058229-93800-3-git-send-email-davvid@gmail.com> (David Aguilar's message of "Sun, 22 May 2011 02:57:09 -0700")
David Aguilar <davvid@gmail.com> writes:
> +resolve_git_prefix() {
> + # If GIT_PREFIX is empty then we cannot use it in tools
> + # that expect to be able to chdir() to its value.
> + if test -z "$GIT_PREFIX"; then
> + GIT_PREFIX=.
> + export GIT_PREFIX
> + fi
> +}
Does this "export" have to be conditional? Otherwise, it would be simpler
to do this upfront at the beginning:
: GIT_PREFIX=${GIT_PREFIX:-.}
next prev parent reply other threads:[~2011-05-23 19:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-14 14:25 git difftool does does not respect current working directory Frédéric Heitzmann
2011-05-16 5:39 ` Junio C Hamano
2011-05-20 3:59 ` David Aguilar
2011-05-20 4:10 ` David Aguilar
2011-05-20 4:31 ` Junio C Hamano
2011-05-20 4:48 ` David Aguilar
2011-05-21 9:35 ` Frédéric Heitzmann
2011-05-22 6:14 ` David Aguilar
2011-05-22 6:30 ` Junio C Hamano
2011-05-22 6:50 ` David Aguilar
2011-05-22 9:57 ` [PATCH 1/3] setup: Provide GIT_PREFIX to built-ins David Aguilar
2011-05-22 9:57 ` [PATCH 2/3] git: Remove handling for GIT_PREFIX David Aguilar
2011-05-22 9:57 ` [PATCH 3/3] git-mergetool--lib: Make vimdiff retain the current directory David Aguilar
2011-05-23 6:36 ` Michael J Gruber
2011-05-23 19:59 ` Junio C Hamano [this message]
2011-05-23 12:09 ` [PATCH 1/3] setup: Provide GIT_PREFIX to built-ins Ævar Arnfjörð Bjarmason
2011-05-25 4:19 ` David Aguilar
[not found] ` <1306058055-93672-1-git-send-email-davvid@gmail.com>
[not found] ` <4DDA0044.2060207@drmicha.warpmail.net>
2011-05-23 8:40 ` David Aguilar
2011-05-23 9:58 ` Michael J Gruber
2011-05-23 16:43 ` Junio C Hamano
2011-05-24 7:23 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vipt1ur15.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=davvid@gmail.com \
--cc=frederic.heitzmann@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).