git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j6t@kdbg.org>,
	Robin Rosenberg <robin.rosenberg@dewire.com>,
	Thomas Rast <trast@student.ethz.ch>,
	git@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] Handle double slashes in make_relative_path()
Date: Sat, 23 Jan 2010 12:14:55 -0800	[thread overview]
Message-ID: <7viqasbmtc.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7vwrz8bnbj.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Sat\, 23 Jan 2010 12\:04\:00 -0800")

Junio C Hamano <gitster@pobox.com> writes:

> I think one issue is what happens when you did this:
>
>     cd //server
>     git --git-dir=//server/repo/repo.git --work-tree=repo
>
> Does msysgit implementation figures out that the work tree is located at
> "//server/repo" when get_git_work_tree() is asked to produce an absolute
> path so that it can be compared with //server/repo/repo.git with the code?
> If it does (with the leading double slash), then "doubled slahses fix" is
> a regression we should do something about it.  If it doesn't, then it
> probably doesn't matter.

Nah, I wasn't thinking straight.  What happens if you did this?

	git --git-dir=//git/repo/repo.git --work-tree=/git/repo

where "//git/repo" is on the "git server" and you are working in local
hierarchy "/git/repo"?

  reply	other threads:[~2010-01-23 20:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22  0:07 [PATCH] Handle double slashes in make_relative_path() Thomas Rast
2010-01-22  1:40 ` Junio C Hamano
2010-01-22  3:05   ` Junio C Hamano
2010-01-22  8:36     ` Johannes Sixt
2010-01-23 11:40       ` Robin Rosenberg
2010-01-23 13:09         ` Johannes Sixt
2010-01-23 13:48           ` Robin Rosenberg
2010-01-23 19:00             ` Johannes Sixt
2010-01-23 20:04           ` Junio C Hamano
2010-01-23 20:14             ` Junio C Hamano [this message]
2010-01-23 20:41               ` Johannes Sixt
2010-01-23 21:01                 ` Sverre Rabbelier
2010-01-24 13:57                   ` Thomas Rast
2010-01-24 19:04                     ` Bernhard R. Link
2010-01-24 20:05                       ` Junio C Hamano
2010-01-24 16:44                 ` Johannes Sixt
2010-01-24 18:31                   ` Junio C Hamano
2010-01-25  1:06                     ` Robin Rosenberg
2010-01-22 21:11   ` Thomas Rast
2010-01-22 23:35     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7viqasbmtc.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=j6t@kdbg.org \
    --cc=robin.rosenberg@dewire.com \
    --cc=torvalds@linux-foundation.org \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).