From: Junio C Hamano <gitster@pobox.com>
To: Peter Krefting <peter@softwolves.pp.se>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3] import-tars: Allow per-tar author and commit message.
Date: Wed, 26 Aug 2009 21:57:16 -0700 [thread overview]
Message-ID: <7viqg96ehf.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: 20090826193015.962A7189B12@perkele
Peter Krefting <peter@softwolves.pp.se> writes:
> + while (<MSG>)
> + {
> + if (/^Committer:\s+([^<>]*)\s+<(.*)>\s*$/i)
> + {
> + $this_committer_name = $1;
> + $this_committer_email = $2;
> + }
> + elsif (/^Author:\s+([^<>]*)\s+<(.*)>\s*$/i)
> + {
> + $this_author_name = $1;
> + $this_author_email = $2;
> + }
> + else
> + {
> + $commit_msg .= $_;
> + }
Do you really want to slurp Committer:/Author: lines from _anywhere_ in
the file? Wouldn't it make more sense to vaguely emulate e-mail message
format with headers, empty-line and then body that is free form?
next prev parent reply other threads:[~2009-08-27 4:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-26 19:26 [PATCH v3] import-tars: Allow per-tar author and commit message Peter Krefting
2009-08-27 4:57 ` Junio C Hamano [this message]
2009-08-27 6:42 ` Peter Krefting
2009-08-28 1:38 ` Junio C Hamano
2009-08-28 18:56 ` Peter Krefting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7viqg96ehf.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peter@softwolves.pp.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox