git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Mar 2009, #03; Wed, 11)
Date: Thu, 12 Mar 2009 13:43:52 -0700	[thread overview]
Message-ID: <7viqmejwtz.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <49B96F1A.3060001@lsrfire.ath.cx> (René Scharfe's message of "Thu, 12 Mar 2009 21:22:50 +0100")

René Scharfe <rene.scharfe@lsrfire.ath.cx> writes:

> Junio C Hamano schrieb:
>> Tonight's 'pu' does not pass its self-test and it is expected; I won't be
>> fixing it and I'm going to bed now.
>
> This fixes a segfault:

Oops, you're right.


> diff --git a/remote.c b/remote.c
> index 68c1a84..ea1841e 100644
> --- a/remote.c
> +++ b/remote.c
> @@ -655,9 +655,9 @@ struct remote *remote_get(const char *name)
>  	struct remote *ret;
>  	int name_given = 0;
>  
>  	read_config();
> -	if (name || strcmp(name, "-"))
> +	if (name && strcmp(name, "-"))
>  		name_given = 1;
>  	else {
>  		name = default_remote_name;
>  		name_given = explicit_default_remote_name;

      reply	other threads:[~2009-03-12 20:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-11  9:26 What's cooking in git.git (Mar 2009, #03; Wed, 11) Junio C Hamano
2009-03-11  9:59 ` Felipe Contreras
2009-03-11 15:01 ` Jay Soffian
2009-03-11 22:37 ` Thomas Rast
2009-03-11 22:40   ` [PATCH] send-email: test --no-thread --in-reply-to combination Thomas Rast
2009-03-12 20:22 ` What's cooking in git.git (Mar 2009, #03; Wed, 11) René Scharfe
2009-03-12 20:43   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7viqmejwtz.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=rene.scharfe@lsrfire.ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).