git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Marius Storm-Olsen <marius@trolltech.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 2/4] Add find_insert_index, insert_at_index and clear_func functions to string_list
Date: Sun, 01 Feb 2009 19:03:39 -0800	[thread overview]
Message-ID: <7viqnto7zo.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 75a7d437c1b32600c509bdef5010e6ac30b6cb08.1233520945.git.marius@trolltech.com

Marius Storm-Olsen <marius@trolltech.com> writes:

> string_list_find_insert_index() and string_list_insert_at_index() enables you to see if an item is in the string_list, and to insert at the appropriate index in the list, if not there.
> This is usefull if you need to manipulate an existing item, if present, and insert a new item if not.
>
> Future mailmap code will use this construct to enable complex (old_name, old_email) -> (new_name, new_email) lookups.
>
> The string_list_clear_func() allows to call a custom cleanup function on each item in a string_list, which is useful is the util member points to a complex structure.

What's with these overlong lines?  You do not have them in your other
patches.

  parent reply	other threads:[~2009-02-02  3:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-01 20:59 [PATCH v2 0/4] Extend mailmap functionality Marius Storm-Olsen
2009-02-01 20:59 ` [PATCH v2 1/4] Add log.mailmap as configurational option for mailmap location Marius Storm-Olsen
2009-02-01 20:59   ` [PATCH v2 2/4] Add find_insert_index, insert_at_index and clear_func functions to string_list Marius Storm-Olsen
2009-02-01 20:59     ` [PATCH v2 3/4] Add map_user() and clear_mailmap() to mailmap Marius Storm-Olsen
2009-02-01 20:59       ` [PATCH v2 4/4] Change current mailmap usage to do matching on both name and email of author/committer Marius Storm-Olsen
2009-02-02  3:03     ` Junio C Hamano [this message]
2009-02-02  7:49       ` [PATCH v2 2/4] Add find_insert_index, insert_at_index and clear_func functions to string_list Marius Storm-Olsen
2009-02-02  3:01   ` [PATCH v2 1/4] Add log.mailmap as configurational option for mailmap location Junio C Hamano
2009-02-02  7:48     ` Marius Storm-Olsen
2009-02-02  7:56       ` Junio C Hamano
2009-02-02  8:26         ` Marius Storm-Olsen
2009-02-02  8:40           ` Junio C Hamano
2009-02-02  3:03 ` [PATCH v2 0/4] Extend mailmap functionality Junio C Hamano
2009-02-02  5:26   ` Sverre Rabbelier
2009-02-02  8:07   ` Marius Storm-Olsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7viqnto7zo.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=marius@trolltech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).