From: Junio C Hamano <gitster@pobox.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 4/3] Add example git-vcs-p4
Date: Sun, 11 Jan 2009 22:29:48 -0800 [thread overview]
Message-ID: <7viqoljaub.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LNX.1.00.0901120026290.19665@iabervon.org> (Daniel Barkalow's message of "Mon, 12 Jan 2009 00:41:19 -0500 (EST)")
Daniel Barkalow <barkalow@iabervon.org> writes:
>> vcs-p4.c:504: warning: ISO C90 forbids mixed declarations and code
>> make: *** [vcs-p4.o] Error 1
>
> I haven't been over the 4/3 stuff for coding style yet. But how do you get
> these warnings?
I thought I have mentioned this already, but...
I compile with (at least) these:
-Wno-pointer-to-int-cast
-Wold-style-definition
-Wdeclaration-after-statement
explicitly specified.
I also run kernel's checkpatch.pl script (but ignoring "more than 80-col
is too long" rule) from time to time.
I consider these are good ways to check style-discipline.
next prev parent reply other threads:[~2009-01-12 6:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 20:12 [RFC PATCH 4/3] Add example git-vcs-p4 Daniel Barkalow
2009-01-12 2:08 ` Junio C Hamano
2009-01-12 5:41 ` Daniel Barkalow
2009-01-12 6:29 ` Junio C Hamano [this message]
2009-01-12 11:46 ` Alex Riesen
2009-01-12 18:36 ` Daniel Barkalow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7viqoljaub.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).