From: Junio C Hamano <gitster@pobox.com>
To: Alexander Potashev <aspotashev@gmail.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] Use is_pseudo_dir_name everywhere
Date: Fri, 09 Jan 2009 18:48:39 -0800 [thread overview]
Message-ID: <7viqonzxiw.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20090109102407.GA4089@myhost> (Alexander Potashev's message of "Fri, 9 Jan 2009 13:24:07 +0300")
Alexander Potashev <aspotashev@gmail.com> writes:
> I didn't think over the support of 'lost+found'.
Yeah, I do not think it is particularly a good idea, but that is what (I
thought) you implied in your original message.
In any case, you can always do
$ git clone -n $there it.git
$ mv it.git/.git . && rmdir it.git && git checkout -f
or something like that (adjust what you move out of it.git when you are
doing a bare clone), so in that sense I do not deeply care about the
motivation of your patch myself.
But I liked the helper function to abstract away the many identical checks
we do for "is it a dot or a dot dot?", and that was the primary reason why
I commented on your patches.
prev parent reply other threads:[~2009-01-10 2:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 23:24 [PATCH 0/2] Allow cloning to an existing empty directory Alexander Potashev
2009-01-08 23:24 ` [PATCH 1/2] " Alexander Potashev
2009-01-08 23:24 ` [PATCH 2/2] Use is_pseudo_dir_name everywhere Alexander Potashev
2009-01-09 7:03 ` Johannes Sixt
2009-01-09 7:22 ` Johannes Sixt
2009-01-09 8:33 ` Junio C Hamano
2009-01-09 10:24 ` Alexander Potashev
2009-01-10 2:48 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7viqonzxiw.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=aspotashev@gmail.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).