From: Junio C Hamano <gitster@pobox.com>
To: Martin Koegler <mkoegler@auto.tuwien.ac.at>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git push: Interpret $GIT_DIR/branches in a Cogito compatible way
Date: Mon, 10 Nov 2008 15:25:09 -0800 [thread overview]
Message-ID: <7viqqv410q.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1226353631-3716-1-git-send-email-mkoegler@auto.tuwien.ac.at> (Martin Koegler's message of "Mon, 10 Nov 2008 22:47:11 +0100")
Martin Koegler <mkoegler@auto.tuwien.ac.at> writes:
> Current git versions ignore everything after # (called <head> in the
> following) when pushing. Older versions (before cf818348f1ab57),
> interpret #<head> as part of the URL, which make git bail out.
>
> Ignoring the <head> part for push (fetch respects them) is unlogical.
> As branches origin from Cogito, it is the best to correct this by
> using the behaviour of cg-push:
>
> push HEAD to remote refs/heads/<head>
>
> Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at>
This message was addressed to me, but is it meant for inclusion?
I do not recall seeing an agreement on what the desired behaviour should
be from (ex-)Cogito users, if this change of behaviour hurts real world
usage of existing git users, andr if so how we ease this change in to the
release.
While I'd personally agree matching with whatever cg-push used to do might
make the most sense in the end, I am not sure changing of behaviour
abruptly like this is a good idea.
I am also not so sure url#branch is illogical; I'd suggest dropping that
line from the commit log message in any case.
> +
> +Depending on the operation, git will use one of the following
> +refsprecs, if you don't provide one on the command line.
> +`<branch>` is the name of this file in `$GIT_DIR/branches` and
> +`<head>` defaults to `master`.
> +
> +git fetch uses:
> +
> +------------
> + refs/heads/<head>:refs/heads/<branch>
> +------------
> +
> +git push uses:
>
> ------------
> - refs/heads/<head>:<repository>
> + HEAD:refs/heads/<head>
> ------------
Why isn't this "refs/heads/<head>:refs/heads/<head>", by the way?
next prev parent reply other threads:[~2008-11-10 23:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-10 21:47 [PATCH] git push: Interpret $GIT_DIR/branches in a Cogito compatible way Martin Koegler
2008-11-10 23:25 ` Junio C Hamano [this message]
2008-11-11 8:37 ` Martin Koegler
2008-11-11 17:25 ` Junio C Hamano
2008-11-11 8:45 ` Mike Ralphson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7viqqv410q.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mkoegler@auto.tuwien.ac.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).