From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Michael J Gruber <michaeljgruber+gmane@fastmail.fm>, git@vger.kernel.org
Subject: Re: [PATCH v2] allow user aliases for the --author parameter
Date: Wed, 27 Aug 2008 10:19:09 -0700 [thread overview]
Message-ID: <7viqtmqstu.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080827122954.GA11986@coredump.intra.peff.net> (Jeff King's message of "Wed, 27 Aug 2008 08:29:54 -0400")
Jeff King <peff@peff.net> writes:
> My only complaint is:
>
>> + strbuf_addf(&buf, "--author=%s", name);
>> + av[++ac] = "--all";
>> + av[++ac] = buf.buf;
>> + av[++ac] = NULL;
>
> I am too lazy to hit "shift", so I would use "-i".
I thought about it after writing the one you saw on the list, but from the
beginning I was planning to do this merely as a demonstration patch that
somebody who is interested in the feature can polish and resubmit with
test and documentation. I didn't bother adding such frills --- that is
part of "polish and resubmit" cycle.
next prev parent reply other threads:[~2008-08-27 17:20 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 9:19 [PATCH] allow user aliases for the --author parameter Michael J Gruber
2008-08-21 13:49 ` Miklos Vajna
2008-08-21 14:30 ` Michael J Gruber
2008-08-21 17:41 ` Alex Riesen
2008-08-21 17:49 ` Alex Riesen
2008-08-21 20:02 ` Jeff King
2008-08-22 6:09 ` Junio C Hamano
2008-08-22 8:27 ` Michael J Gruber
2008-08-22 16:50 ` Jeff King
2008-08-22 21:09 ` Junio C Hamano
2008-08-22 21:19 ` Jeff King
2008-08-26 8:02 ` [PATCH v2] " Michael J Gruber
2008-08-26 23:31 ` Junio C Hamano
2008-08-27 0:19 ` Jeff King
2008-08-27 6:13 ` Junio C Hamano
2008-08-27 9:36 ` Michael J Gruber
2008-08-27 12:40 ` Jeff King
[not found] ` <20080827123656.GB11986@coredump.intra.peff.net>
[not found] ` <7vmyiyqt08.fsf@gitster.siamese.dyndns.org>
2008-08-27 17:18 ` Jeff King
2008-08-28 8:53 ` Michael J Gruber
2008-08-28 21:33 ` Jeff King
[not found] ` <7vr68aqt3h.fsf@gitster.siamese.dyndns.org>
[not found] ` <48B65922.4050005@fastmail.fm>
2008-08-28 21:36 ` Jeff King
2008-08-27 12:29 ` Jeff King
2008-08-27 17:19 ` Junio C Hamano [this message]
2008-08-24 9:19 ` [PATCH] " Pedro Melo
2008-08-24 17:21 ` Jeff King
2008-08-25 1:38 ` [PATCH] fix "git log -i --grep" Jeff King
2008-08-25 2:10 ` [PATCH] format-patch: use default diff format even with patch options Jeff King
2008-08-25 4:57 ` Junio C Hamano
2008-08-25 5:12 ` [PATCH] fix "git log -i --grep" Junio C Hamano
2008-08-25 6:15 ` Jeff King
2008-08-25 6:18 ` Jeff King
2008-08-25 6:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7viqtmqstu.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=michaeljgruber+gmane@fastmail.fm \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).