git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "David Kågedal" <davidk@lysator.liu.se>
Cc: git@vger.kernel.org, Nikolaj Schumacher <n_schumacher@web.de>
Subject: Re: [PATCH] Don't cut off last character of commit descriptions.
Date: Wed, 16 Jul 2008 14:11:41 -0700	[thread overview]
Message-ID: <7viqv5pm9e.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <87k5g7fb05.fsf@lysator.liu.se> (David Kågedal's message of "Mon, 30 Jun 2008 12:55:06 +0200")

David Kågedal <davidk@lysator.liu.se> writes:

> Nikolaj Schumacher <n_schumacher@web.de> writes:
>
>> From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001
>> From: Nikolaj Schumacher <git@nschum.de>
>> Date: Mon, 30 Jun 2008 12:06:01 +0200
>> Subject: [PATCH] Don't cut off last character of commit descriptions.
>>
>> ---
>>  contrib/emacs/git-blame.el |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
>> index 9f92cd2..4fa70c5 100644
>> --- a/contrib/emacs/git-blame.el
>> +++ b/contrib/emacs/git-blame.el
>> @@ -381,7 +381,7 @@ See also function `git-blame-mode'."
>>                    "log" "-1"
>>  		  (concat "--pretty=" git-blame-log-oneline-format)
>>                    hash)
>> -    (buffer-substring (point-min) (1- (point-max)))))
>> +    (buffer-substring (point-min) (point-max))))
>>  
>>  (defvar git-blame-last-identification nil)
>>  (make-variable-buffer-local 'git-blame-last-identification)
>
> Yes, this should have been part of
> 24a2293ad35d567530048f0d2b0d11e0012af26d git-blame.el: show the when,
> who and what in the minibuffer. that changed from using
> --pretty=oneline to --pretty=format:... without terminating newline.

Sorry, I realize I haven't applied the patch from Nikolaj.  Should I take
this as an Ack?

      reply	other threads:[~2008-07-16 21:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-30 10:08 [PATCH] Don't cut off last character of commit descriptions Nikolaj Schumacher
2008-06-30 10:55 ` David Kågedal
2008-07-16 21:11   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7viqv5pm9e.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=davidk@lysator.liu.se \
    --cc=git@vger.kernel.org \
    --cc=n_schumacher@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).