git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Jörg Sommer" <joerg@alea.gnuu.de>, git@vger.kernel.org
Subject: Re: git-merge adds test to a message -- bug?
Date: Mon, 24 Mar 2008 09:45:49 -0700	[thread overview]
Message-ID: <7viqzcvznm.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LSU.1.00.0803241208400.4353@racer.site> (Johannes Schindelin's message of "Mon, 24 Mar 2008 12:08:59 +0100 (CET)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> On Sun, 23 Mar 2008, Junio C Hamano wrote:
>
>> I unfortunately do not recall why _prepend_, and not _replace_, had to be
>> the right behaviour.
>
> http://article.gmane.org/gmane.comp.version-control.git/31896/match=git+merge+make+usable
>
> Hth,

Ok, it helped.

So it was "my suspicion that people who would want to pass -m would want
it to behave this way".

I do not care deeply either way myself, as I never have found use for -m
to the merge command, but I think it could have been argued either way.
"If you want to include the standard message, you can do so yourself by
running the fmt-merge-msg yourself" would have been a valid argument too,
even though it would make it a lot more cumbersome if many people wanted
the standard message anyway.

I do not see any objections to the suspicion back then in the thread,
there may have been discussions and user requests that made me suspect
that nearby as well, and ever since the feature was defined that way there
wasn't any objection until Jörg brought this up.

So I'd say we should let the sleeping dog lie for now.

  reply	other threads:[~2008-03-24 16:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-23 23:13 git-merge adds test to a message -- bug? Jörg Sommer
2008-03-24  5:17 ` Junio C Hamano
2008-03-24 11:08   ` Johannes Schindelin
2008-03-24 16:45     ` Junio C Hamano [this message]
2008-03-25  0:12       ` Jörg Sommer
2008-03-25 20:04         ` Johannes Schindelin
2008-04-09 10:40           ` Jörg Sommer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7viqzcvznm.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=joerg@alea.gnuu.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).