From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] "git push": tellme-more protocol extension
Date: Thu, 20 Mar 2008 21:47:01 -0700 [thread overview]
Message-ID: <7viqzgu1iy.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080321042821.GA5453@coredump.intra.peff.net> (Jeff King's message of "Fri, 21 Mar 2008 00:28:21 -0400")
Jeff King <peff@peff.net> writes:
> On Thu, Mar 20, 2008 at 09:24:18PM -0700, Junio C Hamano wrote:
>
>> So a potential improvement might be to ask for "tellme-more" only if we do
>> not know any of the refs the receiver showed us; my patch does it if there
>> is at least one unknown instead.
>
> You can still get cases where doing this is more expensive than your
> patch, because A..B is very small but shared_tag..A is very large. I'm
> not sure which is more likely in practice.
Oh, I have a few fix-ups since I sent the patch, but I am not planning to
experiment with _your_ protocol myself. Debugging one protocol extension
a week is painful enough ;-)
And tellme-more does not send _every_ commit. The sender asks only about
the refs it does not know about, and the receiver sends densely near the
tip and then walks sparsely as it goes deeper, so the traffic wouldn't be
so bad. Latency might be a different story, though.
prev parent reply other threads:[~2008-03-21 4:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 7:58 [PATCH] "git push": tellme-more protocol extension Junio C Hamano
2008-03-21 2:33 ` Jeff King
2008-03-21 4:24 ` Junio C Hamano
2008-03-21 4:28 ` Jeff King
2008-03-21 4:47 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7viqzgu1iy.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).