* [DOC BUG] git tag uses GIT_COMMITTER_DATE, not GIT_AUTHOR_DATE
@ 2008-02-11 8:38 Kalle Olavi Niemitalo
2008-02-11 9:09 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Kalle Olavi Niemitalo @ 2008-02-11 8:38 UTC (permalink / raw)
To: git
In Git v1.5.4.1, Documentation/git-tag.txt advises:
> To set the date used in future tag objects, set the environment
> variable GIT_AUTHOR_DATE to one or more of the date and time. The
> date and time can be specified in a number of ways; the most common
> is "YYYY-MM-DD HH:MM".
But this does not work because git tag uses GIT_COMMITTER_DATE instead.
In builtin-tag.c:
> header_len = snprintf(header_buf, sizeof(header_buf),
> "object %s\n"
> "type %s\n"
> "tag %s\n"
> "tagger %s\n\n",
> sha1_to_hex(object),
> typename(type),
> tag,
> git_committer_info(IDENT_ERROR_ON_NO_NAME));
i.e. it does not call git_author_info.
The backdating section was added to git-tag.txt in 5040beff,
and builtin-tag.c already used git_committer_info at that time.
The older git-tag.sh used tagger=$(git-var GIT_COMMITTER_IDENT).
Thus it seems the bug is in the documentation, not in the code.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [DOC BUG] git tag uses GIT_COMMITTER_DATE, not GIT_AUTHOR_DATE
2008-02-11 8:38 [DOC BUG] git tag uses GIT_COMMITTER_DATE, not GIT_AUTHOR_DATE Kalle Olavi Niemitalo
@ 2008-02-11 9:09 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2008-02-11 9:09 UTC (permalink / raw)
To: Kalle Olavi Niemitalo; +Cc: git
Kalle Olavi Niemitalo <kon@iki.fi> writes:
> In Git v1.5.4.1, Documentation/git-tag.txt advises:
>
>> To set the date used in future tag objects, set the environment
>> variable GIT_AUTHOR_DATE to one or more of the date and time. The
>> date and time can be specified in a number of ways; the most common
>> is "YYYY-MM-DD HH:MM".
>
> But this does not work because git tag uses GIT_COMMITTER_DATE instead.
> In builtin-tag.c:
>
>> header_len = snprintf(header_buf, sizeof(header_buf),
>> "object %s\n"
>> "type %s\n"
>> "tag %s\n"
>> "tagger %s\n\n",
>> sha1_to_hex(object),
>> typename(type),
>> tag,
>> git_committer_info(IDENT_ERROR_ON_NO_NAME));
>
> i.e. it does not call git_author_info.
>
> The backdating section was added to git-tag.txt in 5040beff,
> and builtin-tag.c already used git_committer_info at that time.
> The older git-tag.sh used tagger=$(git-var GIT_COMMITTER_IDENT).
> Thus it seems the bug is in the documentation, not in the code.
Correct. We've always used committer ident as far as I can
remember.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-11 9:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-11 8:38 [DOC BUG] git tag uses GIT_COMMITTER_DATE, not GIT_AUTHOR_DATE Kalle Olavi Niemitalo
2008-02-11 9:09 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).