From: Junio C Hamano <gitster@pobox.com>
To: "Govind Salinas" <govind@sophiasuchtig.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] commit.c: guard config parser from value=NULL
Date: Sat, 09 Feb 2008 18:57:43 -0800 [thread overview]
Message-ID: <7vir0x5xi0.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <5d46db230802091216h40f88f06r20ebb84de6717af6@mail.gmail.com> (Govind Salinas's message of "Sat, 9 Feb 2008 14:16:10 -0600")
"Govind Salinas" <govind@sophiasuchtig.com> writes:
> - if (!strcmp(var, "user.name")) {
> + if (value && !strcmp(var, "user.name")) {
> strlcpy(git_default_name, value, sizeof(git_default_name));
> return 0;
> }
This is wrong, isn't it? When somebody says
[user]
name
we should not silently ignore it, but instead say "user.name is
not a bool!" and error out.
The same comment applies to all other
if (value && !strcmp(var, "<varname>"))
conversions.
prev parent reply other threads:[~2008-02-10 2:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-09 20:16 [PATCH] commit.c: guard config parser from value=NULL Govind Salinas
2008-02-10 2:57 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vir0x5xi0.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=govind@sophiasuchtig.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).