From: Junio C Hamano <gitster@pobox.com>
To: Yasushi SHOJI <yashi@atmark-techno.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: convert from perl internal to utf8 for commitdiff_plain
Date: Mon, 28 Jan 2008 21:39:27 -0800 [thread overview]
Message-ID: <7vir1dqjg0.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <87ve5dicih.wl@mail2.atmark-techno.com> (Yasushi SHOJI's message of "Tue, 29 Jan 2008 11:14:00 +0900")
Yasushi SHOJI <yashi@atmark-techno.com> writes:
> This patch effectively revert the commitdiff plain part of the commit
>
> 59b9f61a3f76762dc975e99cc05335a3b97ad1f9
>
> which converted from print to here-doc. but it doesn't
> explain why in the commit log.
I think the patch makes sense but the above is misleading. Read
it again.
Doesn't it sound like you are accusing that 59b9f61a introduced
a regression when it converted existsing "print utf8()" to
"print <<here-doc" without saying that is what it is doing?
I think the change in that commit was meant for writability (I
do not necessarily think here-doc is good for readability), and
I personally do not care---Perl is ugly to read either way ;-)
next prev parent reply other threads:[~2008-01-29 5:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-29 2:14 [PATCH] gitweb: convert from perl internal to utf8 for commitdiff_plain Yasushi SHOJI
2008-01-29 3:11 ` Ismail Dönmez
2008-01-29 5:39 ` Junio C Hamano [this message]
2008-01-29 5:45 ` Yasushi SHOJI
2008-01-29 5:52 ` Junio C Hamano
2008-01-29 12:16 ` Yasushi SHOJI
2008-01-29 12:40 ` Jakub Narebski
2008-01-30 5:10 ` Junio C Hamano
2008-01-29 11:09 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vir1dqjg0.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=yashi@atmark-techno.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).