From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: make test failure with latest master Date: Mon, 03 Dec 2007 15:21:55 -0800 Message-ID: <7vir3fe54c.fsf@gitster.siamese.dyndns.org> References: <4752A53E.4030000@gmail.com> <20071202163426.GA29781@coredump.intra.peff.net> <47533D75.1090002@gmail.com> <20071203015954.GB8322@coredump.intra.peff.net> <47548CEC.6010701@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jeff King , Johannes Schindelin , git@vger.kernel.org, gitster@pobox.com To: gitzilla@gmail.com X-From: git-owner@vger.kernel.org Tue Dec 04 00:23:00 2007 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1IzKcO-0004H9-Ll for gcvg-git-2@gmane.org; Tue, 04 Dec 2007 00:22:29 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751116AbXLCXWH (ORCPT ); Mon, 3 Dec 2007 18:22:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750942AbXLCXWG (ORCPT ); Mon, 3 Dec 2007 18:22:06 -0500 Received: from sceptre.pobox.com ([207.106.133.20]:38167 "EHLO sceptre.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbXLCXWF (ORCPT ); Mon, 3 Dec 2007 18:22:05 -0500 Received: from sceptre (localhost.localdomain [127.0.0.1]) by sceptre.pobox.com (Postfix) with ESMTP id 71EB0321; Mon, 3 Dec 2007 18:22:26 -0500 (EST) Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by sceptre.sasl.smtp.pobox.com (Postfix) with ESMTP id B39D89C9E1; Mon, 3 Dec 2007 18:22:18 -0500 (EST) In-Reply-To: <47548CEC.6010701@gmail.com> (A. Large Angry's message of "Mon, 03 Dec 2007 18:10:36 -0500") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: A Large Angry SCM writes: > Jeff King wrote: >> On Sun, Dec 02, 2007 at 11:41:10PM +0000, Johannes Schindelin wrote: >> >>>> Attached is the output of >>>> >>>> ./t9600-cvsimport.sh --verbose >/tmp/9600_out.txt 2>&1 >>>> >>> Unfortunately you attached the interesting part, so I cannot quote >>> it here. Seems that your cvsps does not understand the "-A" >>> option. So it looks like it is too old. > > [Ignoring gitte's declaration that the core of git is dependent on CVS] > >> Yes, the changelog indicates that -A was added in 2.1, and he is running >> 2.0rc1. >> >> We can do something like this, though it feels a bit hack-ish and will >> need updated for new cvsps versions (a less lazy or more clever shell >> coder than me could do a nice >= version comparator). > > The patch "fixes" the issue for me. > >> -- >8 -- >> t9600: require cvsps 2.1 to perform tests >> >> git-cvsimport won't run at all with less than cvsps 2.1, because it >> lacks the -A flag. But there's no point in preventing people who have an >> old cvsps from running the full testsuite. >> >> Signed-off-by: Jeff King > > Acked-by: A Large Angry SCM It would be Tested-by: in a stricter sense of the word but thanks for testing. Jeff, would you want to further amend the patch to use "say" as Hannes suggested to make it look nicer?