From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [RFC] use typechange as rename source
Date: Wed, 28 Nov 2007 16:02:49 -0800 [thread overview]
Message-ID: <7vir3l2a1i.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071121171235.GA32233@sigill.intra.peff.net> (Jeff King's message of "Wed, 21 Nov 2007 12:12:36 -0500")
Jeff King <peff@peff.net> writes:
> There are a few add-on questions:
>
> - should typechanges in both directions be used, or just file ->
> symlink?
>
> - this actually produces a 'copied' status rather than a 'renamed'
> since the 'foo' entry does still exist. Is this reasonable?
I do not think this is a risky change; it won't add too many rename
sources we did not consider traditionally (typechanges are usually rare
event anyway).
You are copying the source to elsewhere and then completely rewriting it
(even making it into a different type), so I do not think 'copied' is so
unreasonable. An alternative would be to say you renamed it and then
created something totally different, which would also be reasonable.
next prev parent reply other threads:[~2007-11-29 0:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-21 17:12 [RFC] use typechange as rename source Jeff King
2007-11-29 0:02 ` Junio C Hamano [this message]
2007-11-29 14:14 ` Jeff King
2007-11-30 1:10 ` Junio C Hamano
2007-11-30 1:57 ` Jeff King
2007-12-01 2:36 ` Junio C Hamano
2007-12-01 4:34 ` Jeff King
2007-12-01 6:08 ` Junio C Hamano
2007-12-01 6:13 ` Junio C Hamano
2007-12-01 6:35 ` Junio C Hamano
2007-12-01 6:49 ` Jeff King
2007-12-02 19:15 ` Junio C Hamano
2007-12-03 1:20 ` Jeff King
2007-12-01 6:17 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vir3l2a1i.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).