From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Björn Steinbrink" <B.Steinbrink@gmx.de>,
"Andreas Ericsson" <ae@op5.se>, "Mike Hommey" <mh@glandium.org>,
git@vger.kernel.org
Subject: Re: git rebase --skip
Date: Thu, 08 Nov 2007 15:52:08 -0800 [thread overview]
Message-ID: <7vir4cz45z.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071108231632.GC29840@sigill.intra.peff.net> (Jeff King's message of "Thu, 8 Nov 2007 18:16:32 -0500")
Jeff King <peff@peff.net> writes:
> Personally, I don't see the point of a --force option; it turns your work
> flow from:
>
> 1. git-rebase --skip
> 2. Oops, I guess I have to reset.
> 3. git-reset --hard; git-rebase --skip
>
> to:
>
> 1. same as above
> 2. same as above
> 3. git-rebase --force --skip
I do not see it as improvement, either, for the same reason you
state.
> AIUI, Andreas's proposal is not so much DWIM as "do the obvious thing,
> but include a safety valve to prevent throwing away work." Is there
> actually a case where it would not have the desired effect?
The user is explicitly saying --skip, so I do not think it is
dangerous even if we unconditionally did "reset --hard" at that
point.
Or we could introduce a new option "--drop" (that's "drop the
current commit and continue") to do so, if people find that the
word "skip" does not sound like a scary destructive operation.
But I do not think that is needed.
next prev parent reply other threads:[~2007-11-09 2:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 22:21 git rebase --skip Mike Hommey
2007-11-07 22:48 ` Johannes Schindelin
2007-11-08 3:23 ` Jeff King
2007-11-08 3:31 ` Jakub Narebski
2007-11-08 10:24 ` Björn Steinbrink
2007-11-08 10:32 ` Andreas Ericsson
2007-11-08 10:44 ` Björn Steinbrink
2007-11-08 23:16 ` Jeff King
2007-11-08 23:52 ` Junio C Hamano [this message]
2007-11-09 1:09 ` Björn Steinbrink
2007-11-09 3:22 ` Jeff King
2007-11-09 10:59 ` Johannes Schindelin
2007-11-09 16:19 ` J. Bruce Fields
2007-11-09 16:26 ` J. Bruce Fields
2007-11-09 17:20 ` Jeff King
2007-11-08 18:43 ` Daniel Barkalow
2007-11-08 19:16 ` Mike Hommey
2007-11-08 19:22 ` Mike Hommey
2007-11-08 23:01 ` Johannes Schindelin
2007-11-08 7:03 ` [PATCH] Do git reset --hard HEAD when using " Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vir4cz45z.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=B.Steinbrink@gmx.de \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).