Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: "Dana How" <danahow@gmail.com>
Cc: Nicolas Pitre <nico@cam.org>, "Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] Enhance unpack-objects for extracting large objects
Date: Fri, 25 May 2007 12:59:28 -0700	[thread overview]
Message-ID: <7viragr7xb.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <56b7f5510705251249u74b754f1y4f8cafd5f5c35f19@mail.gmail.com> (Dana How's message of "Fri, 25 May 2007 12:49:08 -0700")

"Dana How" <danahow@gmail.com> writes:

>>  * You already have the size here, so if min_blob_size is set
>>    and the size is larger, you do not even have to call
>>    write_sha1_file() at all.
> The way I read the code,  it looks like unpack-objects needs
> the last argument always to be initialized with the SHA-1 computed
> from the object contents.  Therefore I always need to call
> write_sha1_file(),  even if I don't want it to write anything.

Ah, that is what I missed.

There is a separate function to only hash, named (surprisingly)
"hash_sha1_file().  Maybe you can teach the caller's "don't
write it out" codepath to call it.

  reply	other threads:[~2007-05-25 19:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-25  8:20 [PATCH] Enhance unpack-objects for extracting large objects Dana How
2007-05-25 13:41 ` Nicolas Pitre
2007-05-25 19:22 ` Junio C Hamano
2007-05-25 19:49   ` Dana How
2007-05-25 19:59     ` Junio C Hamano [this message]
2007-05-25 20:05       ` Nicolas Pitre
2007-05-25 19:52   ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7viragr7xb.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=danahow@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=nico@cam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox