From: Junio C Hamano <junkio@cox.net>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Carlos Rica <jasampler@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] fix memory leak in parse_object when check_sha1_signature fails
Date: Thu, 24 May 2007 19:38:46 -0700 [thread overview]
Message-ID: <7virahtyo9.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070525020939.GT28023@spearce.org> (Shawn O. Pearce's message of "Thu, 24 May 2007 22:09:39 -0400")
"Shawn O. Pearce" <spearce@spearce.org> writes:
> Carlos Rica <jasampler@gmail.com> wrote:
>> When check_sha1_signature fails, program is not terminated:
>> it prints an error message and returns NULL, so the
>> buffer returned by read_sha1_file should be freed before.
> ...
>> if (check_sha1_signature(sha1, buffer, size, typename(type))
>> < 0) {
> ...
>
> gmail strikes again. The above line is wrapped, which means your
> patch is whitespace damaged and won't apply properly.
That is only between your eyes, imagination and your MUA (hint:
"format: flowed").
For applying after saving it in mbox it does not pose a problem,
but it _does_ affect people who want to comment on the patch
while in MUA.
Is there a way to turn that "format: flawed" off?
prev parent reply other threads:[~2007-05-25 2:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-25 1:46 [PATCH] fix memory leak in parse_object when check_sha1_signature fails Carlos Rica
2007-05-25 2:09 ` Shawn O. Pearce
2007-05-25 2:38 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7virahtyo9.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=jasampler@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox