From: Junio C Hamano <junkio@cox.net>
To: Liu Yubao <yubao.liu@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] remove unnecessary loop
Date: Mon, 07 May 2007 22:05:53 -0700 [thread overview]
Message-ID: <7virb352ha.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <4640015F.1080407@gmail.com> (Liu Yubao's message of "Tue, 08 May 2007 12:49:35 +0800")
Liu Yubao <yubao.liu@gmail.com> writes:
> Here is a ugly fix, I don't hope it will be merged into git tree as it's not
> git's fault, I will file a bug report for Cygwin.
> @@ -50,9 +53,18 @@ static void prune_directory(struct dir_struct *dir, const char **pathspec, int p
> continue;
>
> /* Existing file? We must have ignored it */
> +#ifdef __CYGWIN__
> + /*
> + * On cygwin, lstat("hello", &st) returns 0 when
> + * "hello.exe" exists, so test with open() again.
> + */
> + if (lstat(match, &st) && -1 != (fd = open(match, O_RDONLY))) {
> + struct dir_entry *ent;
> + close(fd);
> +#else
We have lstat() everywhere, so if we were to work this around
without (or "waiting for") a proper fix on the Cygwin side, you
would be better off wrapping the above sequence in a separate
function (say "sane_lstat()"), and do
#ifdef __CYGWIN__
#define lstat(a,b) sane_lstat(a,b)
#endif
somewhere near the top of git-compat-util.h
next prev parent reply other threads:[~2007-05-08 5:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-08 3:18 [PATCH] remove unnecessary loop Liu Yubao
2007-05-08 4:49 ` Liu Yubao
2007-05-08 5:05 ` Junio C Hamano [this message]
2007-05-08 9:08 ` Alex Riesen
2007-05-08 10:13 ` Jan Hudec
2007-05-08 12:38 ` Alex Riesen
2007-05-08 12:17 ` Eric Blake
2007-05-08 9:39 ` Jan Hudec
2007-05-09 1:03 ` Liu Yubao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7virb352ha.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=yubao.liu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).