From: Junio C Hamano <junkio@cox.net>
To: "James Bowes" <jbowes@dangerouslyinc.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Read cvsimport options from repo-config
Date: Mon, 05 Feb 2007 20:26:17 -0800 [thread overview]
Message-ID: <7vireflxna.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <3f80363f0702051722x1812228fp1cd7a41dd32b31f3@mail.gmail.com> (James Bowes's message of "Mon, 5 Feb 2007 20:22:25 -0500")
I find what your patch does quite sensible, although the
split(/ *(?!:)/) magic might be a bit hard to read for the
uninitiated.
> + my $arg = 'git-repo-config';
> + $arg .= ' --bool' if ($o !~ /:$/);
> +
> + chomp(my $tmp = `$arg --get cvsimport.$key`);
> + if ($tmp && !($arg =~ / --bool / && $tmp eq 'false')) {
Can this =~ / --bool / ever match (note the SP after 'l')?
next prev parent reply other threads:[~2007-02-06 4:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 1:22 [PATCH] Read cvsimport options from repo-config James Bowes
2007-02-06 4:26 ` Junio C Hamano [this message]
2007-02-07 22:57 ` James Bowes
2007-02-11 5:13 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vireflxna.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=jbowes@dangerouslyinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).