From: Junio C Hamano <junkio@cox.net>
To: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fail softly if file system does not like test data.
Date: Wed, 31 Jan 2007 14:17:51 -0800 [thread overview]
Message-ID: <7viremu9gw.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 200701310110.04429.robin.rosenberg.lists@dewire.com
[-- Attachment #1: Type: text/plain, Size: 749 bytes --]
Your patch does not seem to apply. I wonder if the test path
needs to be that looooooooooooong to begin with.
One thing I noticed on Cygwin is that from inside Cygwin
environment t/trash directory becomes unremovable after the
original test fails.
I am wondering what use it would be to have ISO-8859-1 pathnames
in our test. As far as the test is concerned I think the point
is to try non-ASCII paths, so I suspect this patch might be less
of an impact.
Sorry for sending an attachement but in this case the patch text
is _not_ in any particular encoding (the preimage is ISO-8859-1
but the postimage is in UTF-8) and transferring it as a textual
patch over e-mail is not possible without a way to annotate each
line which encoding it is in.
[-- Attachment #2: Re-code the non-ascii path test to use UTF-8. --]
[-- Type: text/x-diff, Size: 2447 bytes --]
diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh
index fd0a554..cc0a254 100755
--- a/t/t9200-git-cvsexportcommit.sh
+++ b/t/t9200-git-cvsexportcommit.sh
@@ -169,19 +169,19 @@ test_expect_success \
test "$(echo $(sort "G g/CVS/Entries"|cut -d/ -f2,3,5))" = "with spaces.png/1.2/-kb with spaces.txt/1.2/"
)'
-# This test contains ISO-8859-1 characters
+# This test contains UTF-8 characters
test_expect_success \
'File with non-ascii file name' \
- 'mkdir -p �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/� &&
- echo Foo >�/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/g�rdets�g�rdet.txt &&
- git add �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/g�rdets�g�rdet.txt &&
- cp ../test9200a.png �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/g�rdets�g�rdet.png &&
- git add �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/g�rdets�g�rdet.png &&
- git commit -a -m "G�r det s� g�r det" && \
+ 'mkdir -p ��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/�� &&
+ echo Foo >��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/��/g��rdets��g��rdet.txt &&
+ git add ��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/��/g��rdets��g��rdet.txt &&
+ cp ../test9200a.png ��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/��/g��rdets��g��rdet.png &&
+ git add ��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/��/g��rdets��g��rdet.png &&
+ git commit -a -m "G��r det s�� g��r det" && \
id=$(git rev-list --max-count=1 HEAD) &&
(cd "$CVSWORK" &&
git-cvsexportcommit -v -c $id &&
- test "$(echo $(sort �/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/�/�/�/CVS/Entries|cut -d/ -f2,3,5))" = "g�rdets�g�rdet.png/1.1/-kb g�rdets�g�rdet.txt/1.1/"
+ test "$(echo $(sort ��/goo/a/b/c/d/e/f/g/h/i/j/k/l/m/n/o/p/q/r/s/t/u/v/w/x/y/z/��/��/��/CVS/Entries|cut -d/ -f2,3,5))" = "g��rdets��g��rdet.png/1.1/-kb g��rdets��g��rdet.txt/1.1/"
)'
test_expect_success \
next prev parent reply other threads:[~2007-01-31 22:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 16:32 t9200-git-cvsexportcommit #8 failure on OS X Brian Gernhardt
2007-01-30 22:20 ` Robin Rosenberg
2007-01-30 22:49 ` [PATCH] Fail softly if file system does not like test data Robin Rosenberg
2007-01-30 23:28 ` Brian Gernhardt
2007-01-31 0:14 ` Robin Rosenberg
2007-01-31 5:39 ` Brian Gernhardt
2007-01-31 0:10 ` Robin Rosenberg
2007-01-31 22:17 ` Junio C Hamano [this message]
2007-01-31 22:36 ` Robin Rosenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7viremu9gw.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg.lists@dewire.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox