From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] Makefile: replace ugly and unportable sed invocation Date: Sun, 02 Jul 2006 11:36:07 -0700 Message-ID: <7virmf4zxk.fsf@assigned-by-dhcp.cox.net> References: <7vr7145u17.fsf@assigned-by-dhcp.cox.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: git@vger.kernel.org X-From: git-owner@vger.kernel.org Sun Jul 02 20:36:21 2006 Return-path: Envelope-to: gcvg-git@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fx6ns-0002y9-Fp for gcvg-git@gmane.org; Sun, 02 Jul 2006 20:36:20 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932454AbWGBSgK (ORCPT ); Sun, 2 Jul 2006 14:36:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932521AbWGBSgJ (ORCPT ); Sun, 2 Jul 2006 14:36:09 -0400 Received: from fed1rmmtao01.cox.net ([68.230.241.38]:35510 "EHLO fed1rmmtao01.cox.net") by vger.kernel.org with ESMTP id S932454AbWGBSgJ (ORCPT ); Sun, 2 Jul 2006 14:36:09 -0400 Received: from assigned-by-dhcp.cox.net ([68.4.9.127]) by fed1rmmtao01.cox.net (InterMail vM.6.01.06.01 201-2131-130-101-20060113) with ESMTP id <20060702183608.FDWQ22974.fed1rmmtao01.cox.net@assigned-by-dhcp.cox.net>; Sun, 2 Jul 2006 14:36:08 -0400 To: Johannes Schindelin In-Reply-To: (Johannes Schindelin's message of "Sun, 2 Jul 2006 11:31:30 +0200 (CEST)") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Archived-At: Johannes Schindelin writes: > First of all, it is _ugly_ (three invocations of sed, where one > really is sufficient). Then, it uses the non-portable ';' > operator, and then, the non-at-all-portable 'T'. > > And worst: it is unnecessary. Thanks -- I was not paying enough attention.