git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Jeff King <peff@peff.net>
Cc: Martin Langhoff <martin.langhoff@gmail.com>,
	git@vger.kernel.org, geoff@austrics.com.au
Subject: Re: Incremental cvsimports
Date: Wed, 24 May 2006 10:05:23 -0700	[thread overview]
Message-ID: <7virnv8ib0.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060524135828.GA23934@coredump.intra.peff.net> (Jeff King's message of "Wed, 24 May 2006 09:58:28 -0400")

Jeff King <peff@peff.net> writes:

> Odd. It's either a bug with importing tags in older versions, or there's
> some deep perl voodoo that I don't understand (either way, it is "fixed"
> in more recent versions).  Importing ENOENT directly is reasonable.

Sounds good.  Thanks for the back-and-forth helping others in
the community.  I appreciate it.

> Junio, can you apply the following fix?

Will do, but I would have preferred if you did the commit log
message and the stuff properly.  Less work for me ;-).

>
> diff --git a/git-cvsimport.perl b/git-cvsimport.perl
> index af331d9..76f6246 100755
> --- a/git-cvsimport.perl
> +++ b/git-cvsimport.perl
> @@ -23,7 +23,7 @@ use File::Basename qw(basename dirname);
>  use Time::Local;
>  use IO::Socket;
>  use IO::Pipe;
> -use POSIX qw(strftime dup2 :errno_h);
> +use POSIX qw(strftime dup2 ENOENT);
>  use IPC::Open2;
>  
>  $SIG{'PIPE'}="IGNORE";

      reply	other threads:[~2006-05-24 17:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-24  7:46 Incremental cvsimports Geoff Russell
2006-05-24  8:21 ` Martin Langhoff
2006-05-24  8:25   ` Martin Langhoff
2006-05-24 11:19   ` Geoff Russell
2006-05-24 12:22     ` Jeff King
2006-05-24 12:33       ` Geoff Russell
2006-05-24 13:23         ` Jeff King
2006-05-24 13:47           ` Geoff Russell
2006-05-24 13:58             ` Jeff King
2006-05-24 17:05               ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7virnv8ib0.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=geoff@austrics.com.au \
    --cc=git@vger.kernel.org \
    --cc=martin.langhoff@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).