git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Joel Becker <Joel.Becker@oracle.com>
Cc: git@vger.kernel.org
Subject: Re: git-commit: allow From: line to be entered in commit message
Date: Fri, 13 Jan 2006 12:33:48 -0800	[thread overview]
Message-ID: <7virsn50lv.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060113200124.GO14196@ca-server1.us.oracle.com> (Joel Becker's message of "Fri, 13 Jan 2006 12:01:24 -0800")

Joel Becker <Joel.Becker@oracle.com> writes:

> On Fri, Jan 13, 2006 at 11:39:17AM -0800, Junio C Hamano wrote:
>> That's what I do.  Although I use git-am not git-applymbox, both
>> of them are designed to work that way.
>
> 	While I can see that git-am and git-applymbox have different
> options for the same basic task, I can't quite see why one would be
> preferred to the other.  What does git-am do that git-applymbox does
> not?

Sorry about the confusion.  This is turning into a FAQ and it is
all _my_ fault [*1*].

Some historical background.

 - "applymbox" was there first.  It was renamed from a tool
   'dotest' Linus had used since BK days, with somewhat
   unextensible command line syntax.

 - "am" was invented later, to majorly redo what applymbox does
   with extensible command line syntax.  It is supposed to do
   everything applymbox does, but the only thing it does not
   support is to be command-line compatible.

The primary reason why I kept applymbox maintained is because
many "How to hack kernel with git" documents floating around
talk about applymbox, and it still is used by Linus to apply
patches with his trained fingers.  Worse yet, it could be that
applymbox is used as a building block in larger private scripts
used by kernel developers, and its removal would force them to
update their scripts to use "am" instead.  I do not want to see
the kernel people spending their time on adjusting their private
tools for git changes unnecessarily; their time is better spent
on improving the kernel.

So in short, I tend to recommend "am" to new people, but
"applymbox" is still usable.


[Footnote]

*1* I do not mind keeping applymbox maintained, but at the same
time I know I would feel it stupid to carry two tools that do
almost the same thing if it were somebody else's project, and
every time this issue comes up I feel the urge to say "in 3
months, git-applymbox will be removed, please get used to
git-am", which so far I ended up resisting.

  reply	other threads:[~2006-01-13 20:33 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060112093700.1d3d25db.seanlkml@sympatico.ca>
2006-01-12 14:37 ` git-commit: allow From: line to be entered in commit message sean
     [not found]   ` <20060112102123.581e373e.seanlkml@sympatico.ca>
2006-01-12 15:21     ` sean
2006-01-12 20:13   ` Junio C Hamano
2006-01-12 21:53     ` Andreas Ericsson
2006-01-12 22:15       ` Junio C Hamano
     [not found]       ` <20060112214307.174f5719.seanlkml@sympatico.ca>
2006-01-13  2:43         ` sean
     [not found]     ` <20060112213207.05d76b28.seanlkml@sympatico.ca>
2006-01-13  2:32       ` sean
2006-01-13  4:03         ` Junio C Hamano
     [not found]           ` <20060112230633.0858694a.seanlkml@sympatico.ca>
2006-01-13  4:06             ` sean
2006-01-13  4:35               ` Junio C Hamano
     [not found]                 ` <20060112235103.42665813.seanlkml@sympatico.ca>
2006-01-13  4:51                   ` sean
2006-01-13 11:11                     ` Artem Khodush
2006-01-13 17:40                       ` Junio C Hamano
     [not found]                         ` <20060113125404.58c4ce30.seanlkml@sympatico.ca>
2006-01-13 17:54                           ` sean
2006-01-13 19:51                             ` Junio C Hamano
2006-01-13 21:53                               ` Johannes Schindelin
2006-01-12 19:00 ` Joel Becker
2006-01-12 20:22   ` Junio C Hamano
2006-01-13  6:58     ` Joel Becker
2006-01-13  7:06       ` Junio C Hamano
2006-01-13 19:12         ` Joel Becker
2006-01-13 19:39           ` Junio C Hamano
2006-01-13 20:01             ` Joel Becker
2006-01-13 20:33               ` Junio C Hamano [this message]
2006-01-13 20:46                 ` Junio C Hamano
2006-01-13 21:47           ` Johannes Schindelin
2006-01-12 20:16 ` Alex Riesen
     [not found]   ` <20060112214642.3c88282c.seanlkml@sympatico.ca>
2006-01-13  2:46     ` sean
2006-01-13  3:58       ` Junio C Hamano
     [not found]         ` <20060112225800.411a04c1.seanlkml@sympatico.ca>
2006-01-13  3:58           ` sean

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7virsn50lv.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=Joel.Becker@oracle.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).