git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: David Aguilar <davvid@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
	Git List <git@vger.kernel.org>,
	Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH v2 3/3] cache.h: eliminate SHA-1 deprecation warnings on OS X 10.8
Date: Sun, 12 May 2013 14:25:05 -0700	[thread overview]
Message-ID: <7vk3n3vqku.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CAJDDKr5QbrY6dFLbdZc2P5fTdLx+MPrSE+r1AAJMU4g=nrV9BA@mail.gmail.com> (David Aguilar's message of "Sun, 12 May 2013 13:57:45 -0700")

David Aguilar <davvid@gmail.com> writes:

> Yup, warnings still remain, but only in imap-send.c.  All the SHA1
> ones are gone.  Those were particularly bothersome since they affected
> several files.
>
> I haven't dug to deeply into how to fix these.  In case anyone has any
> pointers, the warnings look like this:
>
> imap-send.c: In function ‘ssl_socket_perror’:
> imap-send.c:185: warning: ‘ERR_error_string’ is deprecated (declared
> at /usr/include/openssl/err.h:279)

Hmph.

I thought your separate imap-send patch switched to CommonCrypto.
Why are you still including from /usr/include/openssl/?

By the way, is CommonCrypo anything "common"?  I am geting an
impression that it is an Apple-only thing, and if that is the case
the naming feels somewhat funny.

  reply	other threads:[~2013-05-12 21:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-11  8:22 [PATCH v2 1/3] Makefile: fix default regex settings on Darwin David Aguilar
2013-05-11  8:22 ` [PATCH v2 2/3] imap-send: eliminate HMAC warnings on OS X 10.8 David Aguilar
2013-05-11  8:22   ` [PATCH v2 3/3] cache.h: eliminate SHA-1 deprecation " David Aguilar
2013-05-12 18:37     ` Eric Sunshine
2013-05-12 20:57       ` David Aguilar
2013-05-12 21:25         ` Junio C Hamano [this message]
2013-05-12 21:47           ` David Aguilar
2013-05-13  1:22         ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vk3n3vqku.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=davvid@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).