From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>,
Marius Storm-Olsen <mstormo@gmail.com>,
dpotapov@gmail.com
Subject: Re: [PATCH 2/4] Makefile: merge two Cygwin configuration sections into one
Date: Mon, 02 Nov 2009 23:46:28 -0800 [thread overview]
Message-ID: <7vk4y8t5ij.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4AEFDA3F.2070405@viscovery.net> (Johannes Sixt's message of "Tue\, 03 Nov 2009 08\:22\:39 +0100")
Johannes Sixt <j.sixt@viscovery.net> writes:
> Ramsay Jones schrieb:
>> diff --git a/Makefile b/Makefile
>> index fea237b..8e1cfc5 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -782,6 +782,8 @@ ifeq ($(uname_O),Cygwin)
>> NO_MMAP = YesPlease
>> NO_IPV6 = YesPlease
>> X = .exe
>> + COMPAT_OBJS += compat/cygwin.o
>> + UNRELIABLE_FSTAT = UnfortunatelyYes
>> endif
>> ifeq ($(uname_S),FreeBSD)
>> NEEDS_LIBICONV = YesPlease
>> @@ -891,10 +893,6 @@ ifeq ($(uname_S),HP-UX)
>> NO_SYS_SELECT_H = YesPlease
>> SNPRINTF_RETURNS_BOGUS = YesPlease
>> endif
>> -ifneq (,$(findstring CYGWIN,$(uname_S)))
>> - COMPAT_OBJS += compat/cygwin.o
>> - UNRELIABLE_FSTAT = UnfortunatelyYes
>> -endif
>> ifdef MSVC
>> GIT_VERSION := $(GIT_VERSION).MSVC
>> pathsep = ;
>
> I think this an obviously good change even outside this series.
Thanks; I think this one makes sense.
prev parent reply other threads:[~2009-11-03 7:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 19:11 [PATCH 2/4] Makefile: merge two Cygwin configuration sections into one Ramsay Jones
2009-11-03 7:22 ` Johannes Sixt
2009-11-03 7:46 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk4y8t5ij.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=mstormo@gmail.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox