git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Fredrik Skolmli <fredrik@frsk.net>,
	git@vger.kernel.org, Nicolas Sebrecht <nicolas.s.dev@gmx.fr>
Subject: Re: [PATCH] Documentation: Clarify which paths git-clean will affect
Date: Tue, 05 May 2009 09:20:49 -0700	[thread overview]
Message-ID: <7vk54v1py6.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <200905051426.18814.trast@student.ethz.ch> (Thomas Rast's message of "Tue\, 5 May 2009 14\:26\:14 +0200")

Thomas Rast <trast@student.ethz.ch> writes:

>  Normally, only files unknown to git are removed, but if the '-x'
>  option is specified, ignored files are also removed. This can, for
>  example, be useful to remove all build products.
>  
> -If any optional `<path>...` arguments are given, only those paths
> -are affected.
> +If any optional `<path>...` arguments are given, those paths are
> +affected.  Otherwise, the cleaning starts at the current directory.

With or without path limiters, clean does not look outside the current
directory; I think the "otherwise" makes things worse than the original.

I'd suggest not touching this paragraph at all, but instead say something
like this at the beginning:

> diff --git i/Documentation/git-clean.txt w/Documentation/git-clean.txt
> index 43b2de7..3550fc0 100644
> --- i/Documentation/git-clean.txt
> +++ w/Documentation/git-clean.txt
> @@ -13,15 +13,15 @@ SYNOPSIS
>  DESCRIPTION
>  -----------
>  
> -This allows cleaning the working tree by removing files that are not
> +Cleans the working tree by recursively removing files that are not
>  under version control.

    Cleans the working tree by recursively removing files that are not
    under version control, starting from the current directory.

  reply	other threads:[~2009-05-05 16:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-05  9:13 [PATCH] Documentation: Clarify which paths git-clean will affect Fredrik Skolmli
2009-05-05  9:55 ` Thomas Rast
2009-05-05 10:05   ` Fredrik Skolmli
2009-05-05 11:17     ` [PATCH] " Nicolas Sebrecht
2009-05-05 12:26     ` [PATCH] " Thomas Rast
2009-05-05 16:20       ` Junio C Hamano [this message]
2009-05-06 13:24         ` Thomas Rast
2009-05-06 16:31           ` Fredrik Skolmli
2009-05-06 17:57             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vk54v1py6.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=fredrik@frsk.net \
    --cc=git@vger.kernel.org \
    --cc=nicolas.s.dev@gmx.fr \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).