From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: git@vger.kernel.org
Subject: Re: Re* ext3: fix ext3_dx_readdir hash collision handling - Regression
Date: Fri, 24 Oct 2008 15:35:03 -0700 [thread overview]
Message-ID: <7vk5bx1v1k.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0810241524350.3287@nehalem.linux-foundation.org> (Linus Torvalds's message of "Fri, 24 Oct 2008 15:26:46 -0700 (PDT)")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Fri, 24 Oct 2008, Junio C Hamano wrote:
>>
>> Subject: allow readdir(3) to return the same entry twice
>
> The thing is, this really is a kernel bug. We have even bisected it (and
> it hasn't hit any released kernel). The original reporter showed it with a
> simple "rm -r".
>
> So it really isn't a git bug, even though I initially thought it might be,
> before I looked closer.
>
> That said, the git patch may be worth it just because two *concurrent*
> invocations of "git clean" could then cause one (or both) to fail this
> way.
Yeah, or on perhaps a buggy implementation of readdir(3) on somebody
else's system. In either case, I just thought it might be a low impact
belt-and-suspenders fix that is worth considering.
prev parent reply other threads:[~2008-10-24 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081022093201.GA2227@gentoox2.trippelsdorf.de>
[not found] ` <20081023032832.GE10369@mit.edu>
[not found] ` <20081023063740.GA2438@gentoox2.trippelsdorf.de>
[not found] ` <20081024000109.GD7842@mit.edu>
[not found] ` <20081024042851.GA2360@gentoox2.trippelsdorf.de>
[not found] ` <alpine.LFD.2.00.0810240853310.3287@nehalem.linux-foundation.org>
2008-10-24 22:00 ` Re* ext3: fix ext3_dx_readdir hash collision handling - Regression Junio C Hamano
2008-10-24 22:26 ` Linus Torvalds
2008-10-24 22:35 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk5bx1v1k.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).