From: Junio C Hamano <gitster@pobox.com>
To: Simon Hausmann <simon@lst.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] [git-p4] Make it possible to abort the submission of a change to Perforce
Date: Wed, 27 Aug 2008 12:20:57 -0700 [thread overview]
Message-ID: <7vk5e2p8me.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200808270937.10577.simon@lst.de> (Simon Hausmann's message of "Wed, 27 Aug 2008 09:30:29 +0200")
Simon Hausmann <simon@lst.de> writes:
> Currently it is not possible to skip the submission of a change to Perforce
> when running git-p4 submit. This patch compares the modification time before
> and after the submit editor invokation and offers a prompt for skipping if
> the submit template file was not saved.
Applied, thanks.
It makes one wonder if mtime is a reliable enough indication or you are
better off comparing the contents, though. The message file the user is
editing is not that big anyway, no?
prev parent reply other threads:[~2008-08-27 19:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 7:30 [PATCH] [git-p4] Make it possible to abort the submission of a change to Perforce Simon Hausmann
2008-08-27 19:20 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk5e2p8me.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=simon@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).