From mboxrd@z Thu Jan  1 00:00:00 1970
From: Junio C Hamano <gitster@pobox.com>
Subject: Re: Re* git-remote SEGV on t5505 test.
Date: Thu, 17 Jul 2008 23:26:46 -0700
Message-ID: <7vk5fjd7x5.fsf@gitster.siamese.dyndns.org>
References: <g5osl6$4g3$1@ger.gmane.org>
 <7vsku7es3n.fsf@gitster.siamese.dyndns.org> <48802DCD.2090704@posdata.co.kr>
 <7vsku7d8ak.fsf_-_@gitster.siamese.dyndns.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: git@vger.kernel.org
To: SungHyun Nam <namsh@posdata.co.kr>
X-From: git-owner@vger.kernel.org Fri Jul 18 08:27:53 2008
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1KJjRX-0002NP-LI
	for gcvg-git-2@gmane.org; Fri, 18 Jul 2008 08:27:52 +0200
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752513AbYGRG0x (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Fri, 18 Jul 2008 02:26:53 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752567AbYGRG0x
	(ORCPT <rfc822;git-outgoing>); Fri, 18 Jul 2008 02:26:53 -0400
Received: from a-sasl-fastnet.sasl.smtp.pobox.com ([207.106.133.19]:39987 "EHLO
	sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752307AbYGRG0w (ORCPT <rfc822;git@vger.kernel.org>);
	Fri, 18 Jul 2008 02:26:52 -0400
Received: from localhost.localdomain (localhost [127.0.0.1])
	by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with ESMTP id A10252CECF;
	Fri, 18 Jul 2008 02:26:51 -0400 (EDT)
Received: from pobox.com (ip68-225-240-77.oc.oc.cox.net [68.225.240.77])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client
 certificate requested) by a-sasl-fastnet.sasl.smtp.pobox.com (Postfix) with
 ESMTPSA id 0B6CF2CECC; Fri, 18 Jul 2008 02:26:48 -0400 (EDT)
In-Reply-To: <7vsku7d8ak.fsf_-_@gitster.siamese.dyndns.org> (Junio C.
 Hamano's message of "Thu, 17 Jul 2008 23:18:43 -0700")
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux)
X-Pobox-Relay-ID: 8225CCFC-5492-11DD-B6A4-CE28B26B55AE-77302942!a-sasl-fastnet.pobox.com
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/88997>

Junio C Hamano <gitster@pobox.com> writes:

> SungHyun Nam <namsh@posdata.co.kr> writes:
>
>>     Is it possible that we can use 'SHELL_PATH' here?
>
> It is not just possible but we really should.  There are other test
> scripts that use hardcoded /bin/sh, but by setting SHELL_PATH the user is
> already telling us that what the vendor has in /bin/sh isn't adequately
> POSIX enough, and we really should try to honor that.
>
> "git grep -n /bin/sh t/t*sh | grep -v ':1:#!'" would tell you which ones
> are suspect.

SungHyun, I did not test this patch myself (all my shells grok $() command
substitutions), so I won't be committing this until/unless I see a "tested
on system X and works fine".