From: Junio C Hamano <gitster@pobox.com>
To: Pierre Habouzit <madcoder@debian.org>
Cc: git@vger.kernel.org, torvalds@linux-foundation.org,
peff@peff.net, Johannes.Schindelin@gmx.de
Subject: Re: [take 2] revision parsing made incremental
Date: Tue, 08 Jul 2008 15:57:27 -0700 [thread overview]
Message-ID: <7vk5fwq90o.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1215523175-28436-1-git-send-email-madcoder@debian.org> (Pierre Habouzit's message of "Tue, 8 Jul 2008 15:19:32 +0200")
Pierre Habouzit <madcoder@debian.org> writes:
> Following Dscho's remarks, I reworked the series to avoid changing
> setup_revisions semantics for now, and only exposed the part that groks
> options (and keep pseudo revision arguments out).
>
> It indeed makes the series smaller, even if the first patch is quite
> long to read, and is just enough for simplifying git-blame in a very
> satisfying way.
All looks good and the result looks much more readable.
Thanks.
prev parent reply other threads:[~2008-07-08 22:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 13:19 [take 2] revision parsing made incremental Pierre Habouzit
2008-07-08 13:19 ` [PATCH 1/3] revisions: split handle_revision_opt from setup_revisions Pierre Habouzit
2008-07-08 13:19 ` [PATCH 2/3] git-blame: migrate to incremental parse-option [1/2] Pierre Habouzit
2008-07-08 13:19 ` [PATCH 3/3] git-blame: migrate to incremental parse-option [2/2] Pierre Habouzit
2008-07-08 17:41 ` [take 2] revision parsing made incremental Linus Torvalds
2008-07-08 22:57 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk5fwq90o.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
--cc=peff@peff.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox