Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: namsh@posdata.co.kr
Cc: git@vger.kernel.org, Pieter de Bie <pdebie@ai.rug.nl>
Subject: Re: bug found (Re: git-fast-export SIGSEGV on solaris + backtrace)
Date: Thu, 03 Jul 2008 01:30:13 -0700	[thread overview]
Message-ID: <7vk5g32wve.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 486C248E.4060205@gmail.com

SungHyun Nam <goweol@gmail.com> writes:

> And the code says it:
>         for (i = 0; i < idnums.size; ++i) {
>                 deco++;
>                 if (deco && deco->base && deco->base->type == 1) {
>
> The 'deco' should be post-incremented? or
> Checking code should be  (i < idnums.size - 1)?

The variable "deco" is a pointer that walks over a hashtable from its
offset 0 to its end, so it can never be NULL (well, the code increments
before it tests the variable for NULLness, so it is clear that the test is
bogus).

What was I smoking when I applied df6a7ff (builtin-fast-export: Add
importing and exporting of revision marks, 2008-06-11), I have to
wonder...

Thanks for the fix.

  reply	other threads:[~2008-07-03 12:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4869B91B.9000709@posdata.co.kr>
2008-07-03  0:59 ` bug found (Re: git-fast-export SIGSEGV on solaris + backtrace) SungHyun Nam
2008-07-03  8:30   ` Junio C Hamano [this message]
2008-07-03 12:50     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vk5g32wve.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=namsh@posdata.co.kr \
    --cc=pdebie@ai.rug.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox