From: Junio C Hamano <gitster@pobox.com>
To: "Karl Hasselström" <kha@treskal.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 2/2] Make old sha1 optional with git update-ref -d
Date: Mon, 02 Jun 2008 22:51:33 -0700 [thread overview]
Message-ID: <7vk5h73w2i.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080602233453.26087.52259.stgit@yoghurt> (Karl Hasselström's message of "Tue, 03 Jun 2008 01:34:53 +0200")
Karl Hasselström <kha@treskal.com> writes:
> Giving the old sha1 is already optional when changing a ref, and it's
> quite handy when running update-ref manually. So make it optional for
> deleting a ref too.
>
> Signed-off-by: Karl Hasselström <kha@treskal.com>
"Handy" is not a very good reason when talking about plumbing command like
update-ref that takes an extra parameter for safety of the last step in
read, operate, verify-and-update sequence.
Although it is not a reason _bad enough_ to make your patch a bad idea,
perhaps you should rethink the problem at the same time? Whatever you are
trying to do cannot be done without manually invoking update-ref directly
by the end user, perhaps that needs to be addressed?
next prev parent reply other threads:[~2008-06-03 5:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-25 16:14 [PATCH 0/3] Make old sha1 optional with git update-ref -d Karl Hasselström
2008-05-25 16:14 ` [PATCH 1/3] Add some tests for " Karl Hasselström
2008-05-25 16:14 ` [PATCH 2/3] Clean up builtin-update-ref's option parsing Karl Hasselström
2008-05-25 18:40 ` Junio C Hamano
2008-05-25 19:32 ` Karl Hasselström
2008-06-02 23:34 ` [PATCH v2 0/2] Make old sha1 optional with git update-ref -d Karl Hasselström
2008-06-02 23:34 ` [PATCH v2 1/2] Clean up builtin-update-ref's option parsing Karl Hasselström
2008-06-02 23:34 ` [PATCH v2 2/2] Make old sha1 optional with git update-ref -d Karl Hasselström
2008-06-03 5:51 ` Junio C Hamano [this message]
2008-06-03 6:49 ` Karl Hasselström
2008-06-03 19:39 ` Junio C Hamano
2008-05-25 16:14 ` [PATCH 3/3] " Karl Hasselström
2008-05-26 10:51 ` Johannes Schindelin
2008-05-26 14:09 ` Karl Hasselström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk5h73w2i.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).