From: Junio C Hamano <gitster@pobox.com>
To: Miklos Vajna <vmiklos@frugalware.org>
Cc: git@vger.kernel.org, Pierre Habouzit <madcoder@debian.org>
Subject: Re: [PATCH] Strbuf documentation: document most functions
Date: Mon, 02 Jun 2008 16:39:26 -0700 [thread overview]
Message-ID: <7vk5h75rv5.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1212447591-4870-1-git-send-email-vmiklos@frugalware.org> (Miklos Vajna's message of "Tue, 3 Jun 2008 00:59:51 +0200")
Miklos Vajna <vmiklos@frugalware.org> writes:
> All functions in strbuf.h are documented, except strbuf_expand() and
> launch_editor().
>
> Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
> ---
>
> Actually this is a bit of request for help,...
In that case,...
> diff --git a/Documentation/technical/api-strbuf.txt b/Documentation/technical/api-strbuf.txt
> index a52e4f3..3879e0e 100644
> --- a/Documentation/technical/api-strbuf.txt
> +++ b/Documentation/technical/api-strbuf.txt
> @@ -1,6 +1,175 @@
> strbuf API
> ==========
>
> -Talk about <strbuf.h>
> +strbuf's can be use in many ways: as a byte array, or to store arbitrary
> +long, overflow safe strings.
>
> -(Pierre, JC)
I expected somebody who touches this file to take hints from these names
before removing them ;-)
I'm still at work so I won't be commenting on them in this message but
I'll take a look at it later. Pierre Cc'ed.
next prev parent reply other threads:[~2008-06-02 23:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-02 22:59 [PATCH] Strbuf documentation: document most functions Miklos Vajna
2008-06-02 23:39 ` Junio C Hamano [this message]
2008-06-03 0:00 ` Johannes Schindelin
2008-06-03 8:42 ` Pierre Habouzit
2008-06-03 15:41 ` René Scharfe
2008-06-04 1:15 ` Miklos Vajna
2008-06-04 7:45 ` Junio C Hamano
2008-06-04 21:20 ` Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk5h75rv5.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).