From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Provide git_config with a callback-data parameter
Date: Wed, 14 May 2008 12:27:14 -0700 [thread overview]
Message-ID: <7vk5hwn0tp.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.DEB.1.00.0805141846370.30431@racer> (Johannes Schindelin's message of "Wed, 14 May 2008 18:46:53 +0100 (BST)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> git_config() only had a function parameter, but no callback data
> parameter. This assumes that all callback functions only modify
> global variables.
>
> With this patch, every callback gets a void * parameter, and it is hoped
> that this will help the libification effort.
Great, as this has also been a pet-peeve of mine for quite some time.
Except the patch has quite a many rejects X-<.
next prev parent reply other threads:[~2008-05-14 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 17:46 [PATCH 0/2] Fix two pet peeves of mine Johannes Schindelin
2008-05-14 17:46 ` [PATCH 1/2] Rename path_list to string_list Johannes Schindelin
2008-05-14 17:46 ` [PATCH 2/2] Provide git_config with a callback-data parameter Johannes Schindelin
2008-05-14 19:27 ` Junio C Hamano [this message]
2008-05-15 1:02 ` Johannes Schindelin
2008-05-15 1:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk5hwn0tp.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).