From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Christian Couder <chriscool@tuxfamily.org>,
Pierre Habouzit <madcoder@debian.org>,
git@vger.kernel.org
Subject: Re: [PATCH] help: Add a missing OPT_END().
Date: Tue, 01 Apr 2008 21:34:05 -0700 [thread overview]
Message-ID: <7vk5jgan9e.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080402034430.GA10360@coredump.intra.peff.net> (Jeff King's message of "Tue, 1 Apr 2008 23:44:31 -0400")
Jeff King <peff@peff.net> writes:
> On Wed, Apr 02, 2008 at 05:47:41AM +0200, Christian Couder wrote:
>
>> Some comments in "parse-options.h" say it is needed,
>> though I did not see a crash without it.
>
> There was no particular reason I didn't put it in; I just didn't know
> about it. So ack from me, assuming it is supposed to be there.
parse-options.c::parse_short_opt() and parse_long_opt() has this loop:
for (; options->type != OPTION_END; options++) {
...
}
So whatever happens to come after builtin_help_options[] may be read from
by this loop when you do not have OPTION_END.
prev parent reply other threads:[~2008-04-02 4:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 3:47 [PATCH] help: Add a missing OPT_END() Christian Couder
2008-04-02 3:44 ` Jeff King
2008-04-02 4:34 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk5jgan9e.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).