From: Junio C Hamano <gitster@pobox.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix line numbers emitted by "git diff --check"
Date: Fri, 15 Feb 2008 23:04:40 -0800 [thread overview]
Message-ID: <7vk5l5crg7.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1203118423-32642-1-git-send-email-jaysoffian@gmail.com> (Jay Soffian's message of "Fri, 15 Feb 2008 18:33:43 -0500")
Jay Soffian <jaysoffian@gmail.com> writes:
> Fixes a problem where git diff --check was emitting incorrect lines
> numbers. Adds a test to verify the fix.
>
> Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
Ahh, our mails crossed, and our fixes are equivalent, but yours
has an additional test, which is always good.
Will steal the test part and squash it in (I've already patched
'maint' with the one I sent out), if you do not mind.
prev parent reply other threads:[~2008-02-16 7:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 23:33 [PATCH] Fix line numbers emitted by "git diff --check" Jay Soffian
2008-02-16 7:04 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk5l5crg7.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jaysoffian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).