git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: "Jay Soffian" <jaysoffian@gmail.com>,
	git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] git-web--browse: improve browser support under OS X
Date: Wed, 13 Feb 2008 14:14:43 -0800	[thread overview]
Message-ID: <7vk5l8o65o.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200802130755.20884.chriscool@tuxfamily.org> (Christian Couder's message of "Wed, 13 Feb 2008 07:55:20 +0100")

Christian Couder <chriscool@tuxfamily.org> writes:

> Le mardi 12 février 2008, Jay Soffian a écrit :
>> On Feb 10, 2008 10:01 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> > Also I wonder why the check for SECURITYSESSIONID your original
>> > had is not good enough for this Mac specific customization?
>>
>> Christian,
>>
>> Any thoughts on Junio's patch vs the original?
>
> I think the original was good and Junio's patch is a good improvement on top 
> of yours.

I think the original that only checked SECURITYSESSIONID was
short, sweet and inexpensive.

Unless somebody comes up with a good reason that the environment
check for SECURITYSESSIONID would misidentify (my understanding
is that it is a MacOS specific hack^Wenvironment variable and
nobody else would have it, but I haven't found authoritative
source), I think the original from Jay is good and I can apply
it to 'master'.

I very much had trouble with the $(uname -s) thing which
unconditionally penalized everybody else, and that was the
primary reason I suggested an alternative to make it cheaper.

  reply	other threads:[~2008-02-13 22:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08 21:23 [PATCH] Improve git-help--browse browser support under OS X jaysoffian+git
2008-02-09 20:20 ` Dmitry Potapov
2008-02-10  2:15   ` Jay Soffian
2008-02-10 12:43     ` Dmitry Potapov
2008-02-10 13:45       ` Christian Couder
2008-02-11  2:13         ` Jay Soffian
2008-02-11  5:03           ` Christian Couder
2008-02-11  2:10       ` Jay Soffian
2008-02-11  2:24 ` [PATCH] git-web--browse: improve " jaysoffian+git
2008-02-11  3:01   ` Junio C Hamano
2008-02-11 14:15     ` Jay Soffian
2008-02-12 16:40     ` Jay Soffian
2008-02-13  6:55       ` Christian Couder
2008-02-13 22:14         ` Junio C Hamano [this message]
2008-02-13 22:46           ` Pieter de Bie
2008-02-14  0:13             ` Jay Soffian
2008-02-14  5:09               ` Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vk5l8o65o.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=jaysoffian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).