From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Pascal Obry <pascal@obry.net>,
Johannes Sixt <j.sixt@viscovery.net>,
Pascal Obry <pascal.obry@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Add format-patch option --no-name-prefix.
Date: Tue, 18 Dec 2007 12:07:48 -0800 [thread overview]
Message-ID: <7vk5nbzrzf.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.0.9999.0712180840060.21557@woody.linux-foundation.org> (Linus Torvalds's message of "Tue, 18 Dec 2007 08:50:01 -0800 (PST)")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Tue, 18 Dec 2007, Pascal Obry wrote:
>
>> Johannes Sixt a écrit :
>> > that we need another diff option for it. Ok, on my keyboard 0 is typed
>> > with the right hand, and 1 with the left hand, but... ??
>>
>> Because you just did not read my follow-up message :)
>>
>> I need this has I do not have the way to change the server applying the
>> patch. So nothing wrong with my hands or fingers :)
> ....
> So I think you'd need separate arguments for the from/to prefixes, and not
> try to shoehorn it into one argument. With possibly some simple form to
> say "no prefix". So maybe something like
>
> --src-prefix=<string> // default "a/"
> --dst-prefix=<string> // default "b/"
> --no-prefix // shorthand for --src-prefix="" --dst-prefix=""
>
> would work for everybody?
One worry I have is that "diff --git" is validated more strictly than
other diffs by "git-apply", and patches generated with arbitrary prefix
would break it. It might make sense to drop " --git" from the patch
header if we allow a/ and b/ to be changed inconsistently.
next prev parent reply other threads:[~2007-12-18 20:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-18 15:42 [PATCH] Add format-patch option --no-name-prefix Pascal Obry
2007-12-18 15:47 ` Pascal Obry
2007-12-18 15:54 ` Johannes Sixt
2007-12-18 15:59 ` Pascal Obry
2007-12-18 16:50 ` Linus Torvalds
2007-12-18 16:54 ` Pascal Obry
2007-12-18 17:06 ` Johannes Schindelin
2007-12-18 17:56 ` Pascal Obry
2007-12-18 18:56 ` [PATCH] Teach diff machinery to display other prefixes than "a/" and "b/" Johannes Schindelin
2007-12-18 19:03 ` Pascal Obry
2007-12-18 19:05 ` Linus Torvalds
2007-12-18 19:32 ` [PATCH v4] " Johannes Schindelin
2007-12-18 19:55 ` Linus Torvalds
2007-12-18 20:07 ` Junio C Hamano [this message]
2007-12-18 16:03 ` [PATCH] Add format-patch option --no-name-prefix Andreas Ericsson
2007-12-18 16:11 ` Pascal Obry
2007-12-19 8:55 ` Andreas Ericsson
2007-12-19 9:21 ` Johannes Sixt
2007-12-18 16:21 ` [PATCH] Teach diff machinery to display other prefixes than "a/" and "b/" Johannes Schindelin
2007-12-18 16:45 ` Pascal Obry
2007-12-18 16:58 ` Johannes Schindelin
2007-12-18 17:02 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk5nbzrzf.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=pascal.obry@gmail.com \
--cc=pascal@obry.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).