From: Junio C Hamano <gitster@pobox.com>
To: Benoit Sigoure <tsuna@lrde.epita.fr>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Fix a small memory leak in builtin-add
Date: Tue, 30 Oct 2007 01:28:32 -0700 [thread overview]
Message-ID: <7vk5p5ngzz.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1193641233-3880-2-git-send-email-tsuna@lrde.epita.fr
Benoit Sigoure <tsuna@lrde.epita.fr> writes:
> prune_directory and fill_directory allocated one byte per pathspec and never
> freed it.
>
> Signed-off-by: Benoit Sigoure <tsuna@lrde.epita.fr>
> ---
> I don't know whether this was intentionnal or not (since it's
> only a matter of having small chunks of memory not being
> reclaimed and I don't think we can enter these functions
> twice, so these are not leaks in the sense that the program
> will consume more and more memory).
I think it was just a slop. Thanks for catching it.
prev parent reply other threads:[~2007-10-30 8:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 7:00 [PATCH] core-tutorial: Catch up with current Git Benoit Sigoure
2007-10-29 7:00 ` [PATCH] Fix a small memory leak in builtin-add Benoit Sigoure
2007-10-30 8:28 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vk5p5ngzz.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=tsuna@lrde.epita.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).